Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

bpo-45019: Fix freeze_modules.py to print argv incase of error#29744

Merged
gvanrossum merged 1 commit into
python:mainpython/cpython:mainfrom
kumaraditya303:mainkumaraditya303/cpython:mainCopy head branch name to clipboard
Nov 24, 2021
Merged

bpo-45019: Fix freeze_modules.py to print argv incase of error#29744
gvanrossum merged 1 commit into
python:mainpython/cpython:mainfrom
kumaraditya303:mainkumaraditya303/cpython:mainCopy head branch name to clipboard

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Nov 24, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@the-knights-who-say-ni

the-knights-who-say-ni commented Nov 24, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@kumaraditya303

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@kumaraditya303

kumaraditya303 commented Nov 24, 2021

Copy link
Copy Markdown
Contributor Author

I signed CLA

@kumaraditya303

kumaraditya303 commented Nov 24, 2021

Copy link
Copy Markdown
Contributor Author

cc @ericsnowcurrently

@kumaraditya303 kumaraditya303 changed the title Fix freeze_modules.py to print error incase of error Fix freeze_modules.py to print argv incase of error Nov 24, 2021
gvanrossum
gvanrossum approved these changes Nov 24, 2021
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@gvanrossum gvanrossum changed the title Fix freeze_modules.py to print argv incase of error bpo-45019: Fix freeze_modules.py to print argv incase of error Nov 24, 2021
@gvanrossum

gvanrossum commented Nov 24, 2021

Copy link
Copy Markdown
Member

The failing tests look like flakes.

@gvanrossum gvanrossum merged commit 256f9c4 into python:main Nov 24, 2021
@bedevere-bot

bedevere-bot commented Nov 24, 2021

Copy link
Copy Markdown

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@kumaraditya303 @remykarem
Fix typo in freeze_modules (python#29744)
dcaa3ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kumaraditya303 @the-knights-who-say-ni @gvanrossum @bedevere-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.