Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-45847: Port _scproxy to PY_STDLIB_MOD (GH-29644)#29644

Merged
tiran merged 1 commit into
python:mainpython/cpython:mainfrom
tiran:bpo-45847-scproxytiran/cpython:bpo-45847-scproxyCopy head branch name to clipboard
Nov 20, 2021
Merged

bpo-45847: Port _scproxy to PY_STDLIB_MOD (GH-29644)#29644
tiran merged 1 commit into
python:mainpython/cpython:mainfrom
tiran:bpo-45847-scproxytiran/cpython:bpo-45847-scproxyCopy head branch name to clipboard

Conversation

@tiran

@tiran tiran commented Nov 19, 2021

Copy link
Copy Markdown
Member

@tiran

tiran commented Nov 19, 2021

Copy link
Copy Markdown
Member Author

On macOS, the Makefile should contain:

MODULE__SCPROXY=yes
MODULE__SCPROXY_CFLAGS=
MODULE__SCPROXY_LDFLAGS=-framework SystemConfiguration -framework CoreFoundation

and setup.py should pick up the settings automatically.

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiran tiran marked this pull request as ready for review November 20, 2021 09:18
@tiran tiran changed the title bpo-45847: Port _scproxy to PY_STDLIB_MOD bpo-45847: Port _scproxy to PY_STDLIB_MOD (GH-29644) Nov 20, 2021
@tiran tiran merged commit 5596909 into python:main Nov 20, 2021
@tiran tiran deleted the bpo-45847-scproxy branch November 20, 2021 09:18
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.