Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-27313: Fix ttk_guionly tests failing on Framework builds on macOS#29411

Merged
ambv merged 2 commits into
python:mainpython/cpython:mainfrom
ambv:fix-guionly-ttk-tests-on-macosambv/cpython:fix-guionly-ttk-tests-on-macosCopy head branch name to clipboard
Nov 5, 2021
Merged

bpo-27313: Fix ttk_guionly tests failing on Framework builds on macOS#29411
ambv merged 2 commits into
python:mainpython/cpython:mainfrom
ambv:fix-guionly-ttk-tests-on-macosambv/cpython:fix-guionly-ttk-tests-on-macosCopy head branch name to clipboard

Conversation

@ambv

@ambv ambv commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

With this change

Ran 308 tests in 6.152s

OK (skipped=7)

== Tests result: SUCCESS ==

Without this change

Ran 308 tests in 4.753s

FAILED (failures=5, skipped=7)
test test_ttk_guionly failed
test_ttk_guionly failed (5 failures)

== Tests result: FAILURE ==

https://bugs.python.org/issue27313

@ambv ambv changed the title Fix ttk_guionly tests failing on Framework builds on macOS bpo-27313: Fix ttk_guionly tests failing on Framework builds on macOS Nov 4, 2021
@ambv ambv removed the skip issue label Nov 4, 2021

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ambv ambv merged commit e52f9be into python:main Nov 5, 2021
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@ambv ambv deleted the fix-guionly-ttk-tests-on-macos branch November 5, 2021 08:53
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 5, 2021
…pythonGH-29411)

(cherry picked from commit e52f9be)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-bot

Copy link
Copy Markdown

GH-29422 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 5, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 5, 2021
…pythonGH-29411)

(cherry picked from commit e52f9be)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-bot

Copy link
Copy Markdown

GH-29423 is a backport of this pull request to the 3.9 branch.

ambv added a commit that referenced this pull request Nov 5, 2021
…GH-29411) (GH-29422)

(cherry picked from commit e52f9be)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull request Nov 5, 2021
…GH-29411) (GH-29423)

(cherry picked from commit e52f9be)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.