Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-45608: Document missing sqlite3 DB-API attributes and methods#29219

Merged
ambv merged 7 commits into
python:mainpython/cpython:mainfrom
erlend-aasland:sqlite-doc-dbapierlend-aasland/cpython:sqlite-doc-dbapiCopy head branch name to clipboard
Oct 28, 2021
Merged

bpo-45608: Document missing sqlite3 DB-API attributes and methods#29219
ambv merged 7 commits into
python:mainpython/cpython:mainfrom
erlend-aasland:sqlite-doc-dbapierlend-aasland/cpython:sqlite-doc-dbapiCopy head branch name to clipboard

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Oct 25, 2021

Copy link
Copy Markdown
Contributor

Document DB-API required attributes and methods:

  • sqlite3.apilevel
  • sqlite3.paramstyle
  • sqlite3.threadsafety
  • sqlite3.Cursor.setinputsizes()
  • sqlite3.Cursor.setoutputsize()

https://bugs.python.org/issue45608

@erlend-aasland erlend-aasland changed the title bpo-45608: Document missing sqlite3 DB-API attributes bpo-45608: Document missing sqlite3 DB-API attributes and methods Oct 25, 2021

@pfmoore pfmoore left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with just one minor nitpick.

Comment thread Doc/library/sqlite3.rst Outdated
@erlend-aasland

erlend-aasland commented Oct 26, 2021

Copy link
Copy Markdown
Contributor Author

PTAL, @pfmoore. Thanks for reviewing!

I also pushed a small wording improvement in b087d3a

@erlend-aasland

Copy link
Copy Markdown
Contributor Author

Thanks, Paul! @malemburg, does this look good to you?

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 28, 2021
…ythonGH-29219)

(cherry picked from commit 88d8a1a)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot

Copy link
Copy Markdown

GH-29281 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 28, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 28, 2021
…ythonGH-29219)

(cherry picked from commit 88d8a1a)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot

Copy link
Copy Markdown

GH-29282 is a backport of this pull request to the 3.9 branch.

@erlend-aasland erlend-aasland deleted the sqlite-doc-dbapi branch October 28, 2021 19:37
@erlend-aasland

Copy link
Copy Markdown
Contributor Author

Thanks, Łukasz!

ambv pushed a commit that referenced this pull request Oct 28, 2021
…H-29219) (GH-29281)

(cherry picked from commit 88d8a1a)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
ambv pushed a commit that referenced this pull request Oct 28, 2021
…H-29219) (GH-29282)

(cherry picked from commit 88d8a1a)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.