Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

bpo-45548: Inline _math.c into _math.h#29181

Closed
brettcannon wants to merge 1 commit into
python:mainpython/cpython:mainfrom
brettcannon:inline-_mathbrettcannon/cpython:inline-_mathCopy head branch name to clipboard
Closed

bpo-45548: Inline _math.c into _math.h#29181
brettcannon wants to merge 1 commit into
python:mainpython/cpython:mainfrom
brettcannon:inline-_mathbrettcannon/cpython:inline-_mathCopy head branch name to clipboard

Conversation

@brettcannon

@brettcannon brettcannon commented Oct 23, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@brettcannon brettcannon requested a review from a team as a code owner October 23, 2021 00:00
@brettcannon brettcannon marked this pull request as draft October 23, 2021 00:01
@brettcannon brettcannon mentioned this pull request Oct 23, 2021
Merged
@brettcannon

brettcannon commented Oct 23, 2021

Copy link
Copy Markdown
Member Author

#29179 is an alternative solution to the same problem.

@mdickinson

mdickinson commented Oct 24, 2021

Copy link
Copy Markdown
Member

Any idea what's wrong with the .vcxproj file here, and how to fix it? I don't have a Windows development environment available, and I suspect that the right way to fix is not to edit .vcxproj by hand. (Or is it?)

@tiran

tiran commented Oct 24, 2021

Copy link
Copy Markdown
Member

Any idea what's wrong with the .vcxproj file here, and how to fix it? I don't have a Windows development environment available, and I suspect that the right way to fix is not to edit .vcxproj by hand. (Or is it?)

TBH that's exactly what I did. :) Brett should have access to a Windows box, though.

@tiran

tiran commented Oct 25, 2021

Copy link
Copy Markdown
Member

PR #29179 has landed. Mark suggested to remove all pre-C99 fallbacks except the fixed log1p function. I borrowed your idea and put the body into _math.h. You both are mentioned as co-authors.

@tiran tiran closed this Oct 25, 2021
@brettcannon brettcannon deleted the inline-_math branch October 25, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran Awaiting requested review from tiran

@mdickinson mdickinson Awaiting requested review from mdickinson

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland will be requested when the pull request is marked ready for review erlend-aasland is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner

@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping will be requested when the pull request is marked ready for review emmatyping is a code owner

@itamaro itamaro Awaiting requested review from itamaro itamaro will be requested when the pull request is marked ready for review itamaro is a code owner

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brettcannon @mdickinson @tiran @the-knights-who-say-ni @bedevere-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.