bpo-9566: Change HANDLE argument parsing to unsigned in msvcrtmodule.c#2904
Merged
zooba merged 1 commit intoJul 27, 2017
python:masterpython/cpython:masterfrom
segevfiner:bpo-9566-pointers-are-unsignedsegevfiner/cpython:bpo-9566-pointers-are-unsignedCopy head branch name to clipboard
Merged
bpo-9566: Change HANDLE argument parsing to unsigned in msvcrtmodule.c#2904zooba merged 1 commit intopython:masterpython/cpython:masterfrom segevfiner:bpo-9566-pointers-are-unsignedsegevfiner/cpython:bpo-9566-pointers-are-unsignedCopy head branch name to clipboard
zooba merged 1 commit into
python:masterpython/cpython:masterfrom
segevfiner:bpo-9566-pointers-are-unsignedsegevfiner/cpython:bpo-9566-pointers-are-unsignedCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix after #2492, I guess the values were truncated before. Tests are failing in Windows x64.
I ran the test suite locally (Default flags) making sure it passes now with the correct Python version.
Barring weird failure from
test.test_uuid.TestInternals.test_ipconfig_getnoderelated to encoding, I think subprocess uses cp1255 while the console seems to be set to cp862 in my computer. Maybe Python should be deciding on the code page for use by subprocess by usingGetConsoleOutputCP. Who knows if that's always the right thing to do...😓
@zooba @Haypo
https://bugs.python.org/issue9566