Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.6] bpo-30119: fix ftplib.FTP.putline() to throw an error for a illegal command (#1214)#2886

Merged
vstinner merged 1 commit into
python:3.6python/cpython:3.6from
corona10:bpo-30119-3.6corona10/cpython:bpo-30119-3.6Copy head branch name to clipboard
Jul 26, 2017
Merged

[3.6] bpo-30119: fix ftplib.FTP.putline() to throw an error for a illegal command (#1214)#2886
vstinner merged 1 commit into
python:3.6python/cpython:3.6from
corona10:bpo-30119-3.6corona10/cpython:bpo-30119-3.6Copy head branch name to clipboard

Conversation

@corona10

@corona10 corona10 commented Jul 26, 2017

Copy link
Copy Markdown
Member

cherry-pick from 2b1e6e9

https://bugs.python.org/issue30119

Comment thread Misc/NEWS Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer update Misc/NEWS but now use the new blurb tool to create individual news entries in Misc/NEWS.d. See https://devguide.python.org/committing/#what-s-new-and-news-entries

Comment thread Misc/NEWS Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blurb entry looks good, thanks, but you also need to remove the change to Misc/NEWS here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's my mistake. sorry about that.
I will update it now.

@corona10 corona10 force-pushed the bpo-30119-3.6 branch 4 times, most recently from cf73da8 to 8cab880 Compare July 26, 2017 07:21
@corona10

Copy link
Copy Markdown
Member Author

@ned-deily Updated!

@vstinner vstinner dismissed ned-deily’s stale review July 26, 2017 12:10

The author created a NEWS.d entry.

@vstinner vstinner merged commit 8c2d4cf into python:3.6 Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.