bpo-16379: Fix SQLite version checks in test_module_constants()#28809
Merged
miss-islington merged 1 commit intoOct 7, 2021
python:mainpython/cpython:mainfrom
erlend-aasland:sqlite-fix-version-checkserlend-aasland/cpython:sqlite-fix-version-checksCopy head branch name to clipboard
Merged
bpo-16379: Fix SQLite version checks in test_module_constants()#28809miss-islington merged 1 commit intopython:mainpython/cpython:mainfrom erlend-aasland:sqlite-fix-version-checkserlend-aasland/cpython:sqlite-fix-version-checksCopy head branch name to clipboard
miss-islington merged 1 commit into
python:mainpython/cpython:mainfrom
erlend-aasland:sqlite-fix-version-checkserlend-aasland/cpython:sqlite-fix-version-checksCopy head branch name to clipboard
Conversation
Contributor
Author
|
@pablogsal Can I reuse issue 16379 for this, or is the skip issue label ok here? |
Contributor
Author
|
GH-27786 (which introduced these tests) was run multiple times with the buildbots. There is apparently too little variation of SQLite versions in the buildbots. |
Member
You can reuse the issue if you wish :) |
pablogsal
approved these changes
Oct 7, 2021
Contributor
Author
|
Thanks, Pablo :) |
Contributor
|
@erlend-aasland: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue16379
Automerge-Triggered-By: GH:pablogsal