Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-31034: Reliable signal handler for test_asyncio#2867

Merged
vstinner merged 2 commits into
python:masterpython/cpython:masterfrom
vstinner:asyncio_sig_dflCopy head branch name to clipboard
Jul 25, 2017
Merged

bpo-31034: Reliable signal handler for test_asyncio#2867
vstinner merged 2 commits into
python:masterpython/cpython:masterfrom
vstinner:asyncio_sig_dflCopy head branch name to clipboard

Conversation

@vstinner

@vstinner vstinner commented Jul 25, 2017

Copy link
Copy Markdown
Member

Don't rely on the current SIGHUP signal handler, make sure that it's
set to the "default" signal handler: SIG_DFL.

https://bugs.python.org/issue31034

Don't rely on the current SIGHUP signal handler, make sure that it's
set to the "default" signal handler: SIG_DFL.
@brettcannon brettcannon changed the title bpo-31034: Reliable signal handler for test_asyncio Reliable signal handler for test_asyncio Jul 25, 2017
@brettcannon brettcannon changed the title Reliable signal handler for test_asyncio bpo-31034: Reliable signal handler for test_asyncio Jul 25, 2017
@brettcannon brettcannon changed the title bpo-31034: Reliable signal handler for test_asyncio Reliable signal handler for test_asyncio Jul 25, 2017
@brettcannon brettcannon changed the title Reliable signal handler for test_asyncio bpo-31034: Reliable signal handler for test_asyncio Jul 25, 2017
@brettcannon

Copy link
Copy Markdown
Member

Sorry about the title change noise: trying to figure out why this PR wasn't editable.

@Mariatta

Copy link
Copy Markdown
Member

It's editable now 👍

@vstinner

Copy link
Copy Markdown
Member Author

why this PR wasn't editable

Did it do something wrong?

@vstinner vstinner merged commit 8300809 into python:master Jul 25, 2017
@vstinner vstinner deleted the asyncio_sig_dfl branch July 25, 2017 17:19
@brettcannon

Copy link
Copy Markdown
Member

@Haypo yep, we ran into a bug in GitHub's API that was automatically turning off the ability to edit PRs by project maintainers. New deployment of Bedevere works around the bug and I used this PR to test the fix. 😀

@vstinner

Copy link
Copy Markdown
Member Author

"New deployment of Bedevere works around the bug and I used this PR to test the fix. 😀"

Oh ok, no problem. It seems like at the end, it works, nice ;-)

@bedevere-bot

Copy link
Copy Markdown

GH-2876 is a backport of this pull request to the 3.6 branch.

vstinner added a commit that referenced this pull request Jul 26, 2017
* bpo-31034: Reliable signal handler for test_asyncio

Don't rely on the current SIGHUP signal handler, make sure that it's
set to the "default" signal handler: SIG_DFL.

* Add comments

(cherry picked from commit 8300809)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.