Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Also install __phello__, in addition to __hello__.#28665

Merged
ericsnowcurrently merged 1 commit into
python:mainpython/cpython:mainfrom
ericsnowcurrently:fix-buildbot-failuresericsnowcurrently/cpython:fix-buildbot-failuresCopy head branch name to clipboard
Oct 1, 2021
Merged

Also install __phello__, in addition to __hello__.#28665
ericsnowcurrently merged 1 commit into
python:mainpython/cpython:mainfrom
ericsnowcurrently:fix-buildbot-failuresericsnowcurrently/cpython:fix-buildbot-failuresCopy head branch name to clipboard

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Oct 1, 2021

Copy link
Copy Markdown
Member

(I was going to revert gh-28664, but realized what the problem was.)

I broke some buildbots by not adding phello to the list of installed packages.

https://bugs.python.org/issue45020

@ericsnowcurrently ericsnowcurrently requested a review from a team as a code owner October 1, 2021 01:45
@ericsnowcurrently ericsnowcurrently changed the title Revert "bpo-45020: Add more test cases for frozen modules. (gh-28664)" Revert "bpo-45020: Add more test cases for frozen modules." Oct 1, 2021
@ericsnowcurrently ericsnowcurrently changed the title Revert "bpo-45020: Add more test cases for frozen modules." Also install __phello__, in addition to __hello__. Oct 1, 2021
@ericsnowcurrently ericsnowcurrently merged commit 3e1c5d9 into python:main Oct 1, 2021
@bedevere-bot

Copy link
Copy Markdown

@ericsnowcurrently: Please replace # with GH- in the commit message next time. Thanks!

@ericsnowcurrently ericsnowcurrently deleted the fix-buildbot-failures branch October 1, 2021 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.