bpo-45229: Revert "Make datetime tests discoverable"#28650
Merged
pablogsal merged 1 commit intoSep 30, 2021
mainpython/cpython:mainfrom
revert-28615-test-datetime-discoverpython/cpython:revert-28615-test-datetime-discoverCopy head branch name to clipboard
Merged
bpo-45229: Revert "Make datetime tests discoverable"#28650pablogsal merged 1 commit intomainpython/cpython:mainfrom revert-28615-test-datetime-discoverpython/cpython:revert-28615-test-datetime-discoverCopy head branch name to clipboard
pablogsal merged 1 commit into
mainpython/cpython:mainfrom
revert-28615-test-datetime-discoverpython/cpython:revert-28615-test-datetime-discoverCopy head branch name to clipboard
Conversation
Member
Author
|
Temporary revert of #28615 until we have a fix for the buildbot fleet |
pganssle
approved these changes
Sep 30, 2021
vstinner
approved these changes
Sep 30, 2021
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM.
Serhiy's enhancement is great, but breaking all Refleaks buildbot is reason good enough to justify a revert.
It seems like it's simple to reproduce the issue, so we can revert and investigate on our side in the meanwhile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #28615
https://bugs.python.org/issue45229