gh-89562: Remove hostflags from PySSLContext#28602
gh-89562: Remove hostflags from PySSLContext#28602gpshead merged 1 commit intopython:mainpython/cpython:mainfrom ramikg:remove-hostflags-from-pysslcontext-structCopy head branch name to clipboard
Conversation
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Is it possible to submit this PR without a bpo? (on the count of it being trivial) |
No, this is not a trivial change. Python requires a ticket for every change that has even a remote chance of affecting a single user. By definition, C and OpenSSL are not trivial, too. |
|
Understood, thank you. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
1 similar comment
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @tiran: please review the changes made to this pull request. |
|
All commit authors signed the Contributor License Agreement. |
The
PySSLContextstruct inModules/_ssl.cmentions that "OpenSSL has no API to get hostflags from X509_VERIFY_PARAM* struct. We have to maintain our own copy".Since OpenSSL 1.1.0i added the function
X509_VERIFY_PARAM_get_hostflags, this statement is no longer true.Because Python 3.10 requires OpenSSL 1.1.1 (PEP 644), we no longer have to maintain a copy of the host flags.
This PR removes the
hostflagsmember from thePySSLContextstruct.https://bugs.python.org/issue45399