Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-45211: Move helpers from getpath.c to internal API.#28550

Merged
ericsnowcurrently merged 12 commits into
python:mainpython/cpython:mainfrom
ericsnowcurrently:config-cleanupericsnowcurrently/cpython:config-cleanupCopy head branch name to clipboard
Sep 27, 2021
Merged

bpo-45211: Move helpers from getpath.c to internal API.#28550
ericsnowcurrently merged 12 commits into
python:mainpython/cpython:mainfrom
ericsnowcurrently:config-cleanupericsnowcurrently/cpython:config-cleanupCopy head branch name to clipboard

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Sep 24, 2021

Copy link
Copy Markdown
Member

This accomplishes 2 things:

  • consolidates some common code between getpath.c and getpathp.c
  • makes the helpers available to code in other files (I'll be doing that in a later PR)

FWIW, the signature of the join_relfile() function (in fileutils.c) intentionally mirrors that of Windows' PathCchCombineEx().

Note that this PR is mostly moving code around. No behavior is meant to change.

https://bugs.python.org/issue45211

@ericsnowcurrently ericsnowcurrently marked this pull request as ready for review September 24, 2021 23:48
@ericsnowcurrently ericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 27, 2021
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 5db4c3d 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 27, 2021
@ericsnowcurrently

Copy link
Copy Markdown
Member Author

I'm fixing the buildbot failure in gh-28584.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.