bpo-31018: Switch to #pragma pack from __declspec(align) in _tracemalloc#2848
Merged
vstinner merged 1 commit intoJul 25, 2017
python:masterpython/cpython:masterfrom
segevfiner:bpo-31018-tracemalloc-pack-optimizationsegevfiner/cpython:bpo-31018-tracemalloc-pack-optimizationCopy head branch name to clipboard
Merged
bpo-31018: Switch to #pragma pack from __declspec(align) in _tracemalloc#2848vstinner merged 1 commit intopython:masterpython/cpython:masterfrom segevfiner:bpo-31018-tracemalloc-pack-optimizationsegevfiner/cpython:bpo-31018-tracemalloc-pack-optimizationCopy head branch name to clipboard
vstinner merged 1 commit into
python:masterpython/cpython:masterfrom
segevfiner:bpo-31018-tracemalloc-pack-optimizationsegevfiner/cpython:bpo-31018-tracemalloc-pack-optimizationCopy head branch name to clipboard
Conversation
5 tasks
Member
|
Thanks. Packing is just an optimization to reduce the memory footprint. It's up to you to decide if it's worth it to backport the change to 3.6 (and maybe also 3.5). |
segevfiner
added a commit
to segevfiner/cpython
that referenced
this pull request
Jul 25, 2017
…honGH-2848) (cherry picked from commit 3924377)
segevfiner
added a commit
to segevfiner/cpython
that referenced
this pull request
Jul 25, 2017
…honGH-2848) (cherry picked from commit 3924377)
Contributor
Author
|
Since it's small... might as well. |
vstinner
pushed a commit
that referenced
this pull request
Jul 25, 2017
vstinner
pushed a commit
that referenced
this pull request
Jul 25, 2017
corona10
pushed a commit
to corona10/cpython
that referenced
this pull request
Jul 26, 2017
…honGH-2848) (python#2869) (cherry picked from commit 3924377)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _tracemalloc
frame_tpacking optimization is not working in Windows x64.For this to actually work we simply need to use
#pragma packinstead.https://bugs.python.org/issue31018