[3.3] bpo-22928: Disabled HTTP header injections in http.client.#2817
Merged
ned-deily merged 2 commits intoJul 26, 2017
python:3.3python/cpython:3.3from
serhiy-storchaka:backport-a112a8a-3.3serhiy-storchaka/cpython:backport-a112a8a-3.3Copy head branch name to clipboard
Merged
[3.3] bpo-22928: Disabled HTTP header injections in http.client.#2817ned-deily merged 2 commits intopython:3.3python/cpython:3.3from serhiy-storchaka:backport-a112a8a-3.3serhiy-storchaka/cpython:backport-a112a8a-3.3Copy head branch name to clipboard
ned-deily merged 2 commits into
python:3.3python/cpython:3.3from
serhiy-storchaka:backport-a112a8a-3.3serhiy-storchaka/cpython:backport-a112a8a-3.3Copy head branch name to clipboard
Conversation
…lient. Original patch by Demian Brecht.. (cherry picked from commit a112a8a)
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pitrou, @gvanrossum and @orsenthil to be potential reviewers. |
Member
|
See my comment on the bpo: http://bugs.python.org/issue22928#msg299053 |
vstinner
reviewed
Jul 25, 2017
|
|
||
| # the patterns for both name and value are more leniant than RFC | ||
| # definitions to allow for backwards compatibility | ||
| _is_legal_header_name = re.compile(rb'[^:\s][^:\r\n]*\Z').match |
Member
There was a problem hiding this comment.
Python 2.7 regex starts with \A. Is it useful?
Member
Author
There was a problem hiding this comment.
No. match() always matches from the start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original patch by Demian Brecht.
(cherry picked from commit a112a8a)
https://bugs.python.org/issue22928