Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-44976: Lazy creation of sqlite3 result rows#27884

Merged
pablogsal merged 1 commit into
python:mainpython/cpython:mainfrom
erlend-aasland:sqlite-fetch-when-needederlend-aasland/cpython:sqlite-fetch-when-neededCopy head branch name to clipboard
Aug 25, 2021
Merged

bpo-44976: Lazy creation of sqlite3 result rows#27884
pablogsal merged 1 commit into
python:mainpython/cpython:mainfrom
erlend-aasland:sqlite-fetch-when-needederlend-aasland/cpython:sqlite-fetch-when-neededCopy head branch name to clipboard

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Aug 22, 2021

Copy link
Copy Markdown
Contributor
  • remove 'next_row' member from Cursor object
  • remove _pysqlite_fetch_one_row() call from query execute loop
  • as a result of the two above, pysqlite_cursor_iternext() is vastly simplified

https://bugs.python.org/issue44976

- remove 'next_row' member in Cursor object
- remove fetch-one-row call from query execute loop
- rewrite cursor iternext method to comply with the new behaviour
@erlend-aasland

Copy link
Copy Markdown
Contributor Author

Internal change; no user-visible or backwards incompatible changes; skipping news.

@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 22, 2021
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit ce0d55f 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 22, 2021
@erlend-aasland

Copy link
Copy Markdown
Contributor Author

The AMD64 Arch Linux Asan Debug PR buildbot failure seems to be unrelated. I see that it's been failing a lot recently.

@pablogsal pablogsal merged commit 3df0fc8 into python:main Aug 25, 2021
@erlend-aasland erlend-aasland deleted the sqlite-fetch-when-needed branch August 25, 2021 10:31
@erlend-aasland

Copy link
Copy Markdown
Contributor Author

Thanks, Pablo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.