Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-28523: IDLE: Use 'color' instead of 'colour'.#2787

Merged
terryjreedy merged 13 commits into
python:masterpython/cpython:masterfrom
terryjreedy:colorterryjreedy/cpython:colorCopy head branch name to clipboard
Jul 21, 2017
Merged

bpo-28523: IDLE: Use 'color' instead of 'colour'.#2787
terryjreedy merged 13 commits into
python:masterpython/cpython:masterfrom
terryjreedy:colorterryjreedy/cpython:colorCopy head branch name to clipboard

Conversation

@terryjreedy

Copy link
Copy Markdown
Member

No description provided.

@mention-bot

Copy link
Copy Markdown

@terryjreedy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @csabella, @kbkaiser and @mlouielu to be potential reviewers.

@mlouielu

Copy link
Copy Markdown
Contributor

Do this need a NEWS entry? thought just a variable changed, but I found that idlelib/ChangeLog has log this changed before (* help.txt: py-csv merge, update colour changing info)

@terryjreedy

Copy link
Copy Markdown
Member Author

Yes, we need a news entry for each issue. If there was only one occurrence, I would have just done it without an issue.

That 2001 patch was to help.txt. Sounds like it updated information on how to change highlight 'colours'.

@terryjreedy terryjreedy merged commit a54a8f1 into python:master Jul 21, 2017
@terryjreedy terryjreedy deleted the color branch July 21, 2017 05:07
terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Jul 21, 2017
terryjreedy added a commit that referenced this pull request Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.