Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-30822: Exclude tzdata from regrtest --all#2775

Merged
vstinner merged 4 commits into
python:masterpython/cpython:masterfrom
vstinner:buildbottestCopy head branch name to clipboard
Jul 20, 2017
Merged

bpo-30822: Exclude tzdata from regrtest --all#2775
vstinner merged 4 commits into
python:masterpython/cpython:masterfrom
vstinner:buildbottestCopy head branch name to clipboard

Conversation

@vstinner

Copy link
Copy Markdown
Member

When running the test suite using --use=all / -u all, exclude tzdata
since it makes test_datetime too slow (15-20 min on some buildbots)
which then times out on some buildbots.

-u tzdata must now be enabled explicitly, -u tzdata or -u all,tzdata,
to run all test_datetime tests.

Fix also regrtest command line parser to allow passing -u
extralargefile to run test_zipfile64.

When running the test suite using --use=all / -u all, exclude tzdata
since it makes test_datetime too slow (15-20 min on some buildbots)
which then times out on some buildbots.

-u tzdata must now be enabled explicitly, -u tzdata or -u all,tzdata,
to run all test_datetime tests.

Fix also regrtest command line parser to allow passing -u
extralargefile to run test_zipfile64.
@vstinner

Copy link
Copy Markdown
Member Author

@serhiy-storchaka: Do you consider that it deserves a NEWS entry?

cc @musically-ut

Replace -u all,-tzdata,-cpu with -u all,-cpu since tzdata is now
excluded from -u all.
@vstinner

Copy link
Copy Markdown
Member Author

@serhiy-storchaka: Do you consider that it deserves a NEWS entry?

Hum, since I now want to backport this change to other branches (especially for the extralargefile fix), I added the NEWS entry ;-)

@serhiy-storchaka serhiy-storchaka added the tests Tests in the Lib/test dir label Jul 20, 2017
@vstinner vstinner merged commit 5b392bb into python:master Jul 20, 2017
@vstinner vstinner deleted the buildbottest branch July 20, 2017 13:46
@bedevere-bot

Copy link
Copy Markdown

GH-2777 is a backport of this pull request to the 3.6 branch.

@bedevere-bot

Copy link
Copy Markdown

GH-2781 is a backport of this pull request to the 3.5 branch.

vstinner added a commit that referenced this pull request Jul 20, 2017
When running the test suite using --use=all / -u all, exclude tzdata
since it makes test_datetime too slow (15-20 min on some buildbots)
which then times out on some buildbots.

-u tzdata must now be enabled explicitly, -u tzdata or -u all,tzdata,
to run all test_datetime tests.

Fix also regrtest command line parser to allow passing -u
extralargefile to run test_zipfile64.

Travis CI: remove -tzdata. Replace -u all,-tzdata,-cpu with -u all,-cpu since tzdata is now excluded from -u all.
(cherry picked from commit 5b392bb)
vstinner added a commit that referenced this pull request Jul 20, 2017
When running the test suite using --use=all / -u all, exclude tzdata
since it makes test_datetime too slow (15-20 min on some buildbots)
which then times out on some buildbots.

-u tzdata must now be enabled explicitly, -u tzdata or -u all,tzdata,
to run all test_datetime tests.

Fix also regrtest command line parser to allow passing -u
extralargefile to run test_zipfile64.

Travis CI: remove -tzdata. Replace -u all,-tzdata,-cpu with -u all,-cpu since tzdata is now excluded from -u all.
(cherry picked from commit 5b392bb)
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @Haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @Haypo, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.