Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-44885: Correct the ast locations of f-strings with format specs and repeated expressions#27729

Merged
pablogsal merged 3 commits into
python:mainpython/cpython:mainfrom
pablogsal:bpo-44885pablogsal/cpython:bpo-44885Copy head branch name to clipboard
Aug 12, 2021
Merged

bpo-44885: Correct the ast locations of f-strings with format specs and repeated expressions#27729
pablogsal merged 3 commits into
python:mainpython/cpython:mainfrom
pablogsal:bpo-44885pablogsal/cpython:bpo-44885Copy head branch name to clipboard

Conversation

@pablogsal

@pablogsal pablogsal commented Aug 11, 2021

Copy link
Copy Markdown
Member

Comment thread Parser/string_parser.c Outdated
Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>

@isidentical isidentical left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal pablogsal merged commit 8e832fb into python:main Aug 12, 2021
@pablogsal pablogsal deleted the bpo-44885 branch August 12, 2021 16:13
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8e832fb2a2cb54d7262148b6ec15563dffb48d63 3.9

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry @pablogsal, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8e832fb2a2cb54d7262148b6ec15563dffb48d63 3.10

pablogsal added a commit to pablogsal/cpython that referenced this pull request Aug 12, 2021
…specs and repeated expressions (pythonGH-27729).

(cherry picked from commit 8e832fb)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-27743 is a backport of this pull request to the 3.10 branch.

@bedevere-bot

Copy link
Copy Markdown

GH-27744 is a backport of this pull request to the 3.9 branch.

pablogsal added a commit to pablogsal/cpython that referenced this pull request Aug 12, 2021
…pecs and repeated expressions (pythonGH-27729).

(cherry picked from commit 8e832fb)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Aug 12, 2021
…specs and repeated expressions (GH-27729) (GH-27743)

(cherry picked from commit 8e832fb)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Aug 12, 2021
…pecs and repeated expressions (GH-27729) (GH-27744)

(cherry picked from commit 8e832fb)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.