bpo-44524: Fix an issue wherein _GenericAlias._name was not properly set for specialforms#27614
Merged
ambv merged 4 commits intoAug 6, 2021
Merged
bpo-44524: Fix an issue wherein _GenericAlias._name was not properly set for specialforms#27614ambv merged 4 commits into
_GenericAlias._name was not properly set for specialforms#27614ambv merged 4 commits into
Conversation
Fidget-Spinner
left a comment
Member
There was a problem hiding this comment.
LGTM in general. Thanks for the quick fix :). I just have a few minor comments below.
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
Contributor
|
GHA Windows 32-bit failure in asyncio unrelated. |
Contributor
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 6, 2021
…y set for specialforms (pythonGH-27614) Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl> (cherry picked from commit 8bdf12e) Co-authored-by: Bas van Beek <43369155+BvB93@users.noreply.github.com>
|
GH-27632 is a backport of this pull request to the 3.10 branch. |
Member
|
Unfortunately this PR has introduced reference leaks: |
Contributor
|
Turns out this PR discovered refleaks that were there all along 😎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An example from prior to this PR:
https://bugs.python.org/issue44524