Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-37788: Fix reference leak when Thread is never joined#27473

Closed
millerjoey975 wants to merge 0 commit into
python:mainpython/cpython:mainfrom
millerjoey975:buildbot-custommillerjoey975/cpython:buildbot-customCopy head branch name to clipboard
Closed

bpo-37788: Fix reference leak when Thread is never joined#27473
millerjoey975 wants to merge 0 commit into
python:mainpython/cpython:mainfrom
millerjoey975:buildbot-custommillerjoey975/cpython:buildbot-customCopy head branch name to clipboard

Conversation

@millerjoey975

@millerjoey975 millerjoey975 commented Jul 30, 2021

Copy link
Copy Markdown

When a Thread is not joined after it has stopped, its lock may remain in the _shutdown_locks
set until interpreter shutdown. If many threads are created this way, the _shutdown_locks
set could therefore grow endlessly. To avoid such a situation, purge expired locks each
time a new one is added or removed.

https://bugs.python.org/issue37788

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@millerjoey975

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@shihai1991

Copy link
Copy Markdown
Member

Sorry. I don't understand why to create this PR again? This patch have been merged in: #26103.

@ambv ambv closed this Jul 31, 2021
@ambv ambv force-pushed the buildbot-custom branch from 16edc6a to be4cb90 Compare July 31, 2021 17:10
@ambv

ambv commented Jul 31, 2021

Copy link
Copy Markdown
Contributor

Indeed, this is a null PR. @millerjoey975, please explain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.