Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-30450: Fix logic for retrying nuget.exe download#2744

Merged
zooba merged 4 commits into
python:masterpython/cpython:masterfrom
zooba:bpo-30450zooba/cpython:bpo-30450Copy head branch name to clipboard
Jul 18, 2017
Merged

bpo-30450: Fix logic for retrying nuget.exe download#2744
zooba merged 4 commits into
python:masterpython/cpython:masterfrom
zooba:bpo-30450zooba/cpython:bpo-30450Copy head branch name to clipboard

Conversation

@zooba

@zooba zooba commented Jul 17, 2017

Copy link
Copy Markdown
Member

Fix logic for retrying nuget.exe download with Python.
Add support for HOST_PYTHON variable.
Clear internal environment variables used in find_python.bat

Add support for HOST_PYTHON variable.
Clear internal environment variables used in find_python.bat
@pitrou

pitrou commented Jul 18, 2017

Copy link
Copy Markdown
Member

Is nuget only used to download Python 3.6? Because AppVeyor already has various Python versions available, including Python 3.6. So you may perhaps set HOST_PYTHON from appveyor.yml.

@zooba zooba closed this Jul 18, 2017
@zooba zooba reopened this Jul 18, 2017
@zooba

zooba commented Jul 18, 2017

Copy link
Copy Markdown
Member Author

@pitrou Good point, I'll add that as well.

I still want it to work in other scenarios, so correctly setting variables on our own machines is not sufficient, but since we can avoid the download dependency here we may as well.

@zooba zooba merged commit 5feda33 into python:master Jul 18, 2017
@zooba zooba deleted the bpo-30450 branch July 18, 2017 17:31
zooba added a commit to zooba/cpython that referenced this pull request Jul 18, 2017
Fix logic for retrying nuget.exe download with Python.
Add support for HOST_PYTHON variable.
Clear internal environment variables used in find_python.bat
Use HOST_PYTHON as the actual Python if it is recent enough.
Adds HOST_PYTHON variable to AppVeyor configuration
zware pushed a commit to zware/cpython that referenced this pull request Sep 4, 2017
Fix logic for retrying nuget.exe download with Python.
Add support for HOST_PYTHON variable.
Clear internal environment variables used in find_python.bat
Use HOST_PYTHON as the actual Python if it is recent enough.
Adds HOST_PYTHON variable to AppVeyor configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.