[3.10] Partially revert "bpo-44676: Add ability to serialize types.Union (GH-27244) (GH-27333)"#27335
Closed
Fidget-Spinner wants to merge 2 commits into
python:3.10python/cpython:3.10from
Fidget-Spinner:partial_revert_3.10Fidget-Spinner/cpython:partial_revert_3.10Copy head branch name to clipboard
Closed
[3.10] Partially revert "bpo-44676: Add ability to serialize types.Union (GH-27244) (GH-27333)"#27335Fidget-Spinner wants to merge 2 commits intopython:3.10python/cpython:3.10from Fidget-Spinner:partial_revert_3.10Fidget-Spinner/cpython:partial_revert_3.10Copy head branch name to clipboard
Fidget-Spinner wants to merge 2 commits into
python:3.10python/cpython:3.10from
Fidget-Spinner:partial_revert_3.10Fidget-Spinner/cpython:partial_revert_3.10Copy head branch name to clipboard
Conversation
Member
Author
|
Exposing a private method for pickling means we need to keep it around with no changes forever since pickling guarantees backwards compatibility. I overlooked this part in GH-27333 (sorry!). Alternatively, we can backport GH-27323. Marking this PR as draft until we decide on what to do. |
Member
My idea is to indeed backport PR27323. But whatever we decide needs to be done as soon as possible, because we don't want to realize that we missed something close the the RC |
Member
Author
|
Closing this in favour of GH-27340. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only need the refactoring parts for future backports. The added support for pickling is removed.
https://bugs.python.org/issue44676