Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

bpo-44353: Document that typing.NewType is now a class#27319

Merged
ambv merged 2 commits into
python:mainpython/cpython:mainfrom
Fidget-Spinner:newtype_docsFidget-Spinner/cpython:newtype_docsCopy head branch name to clipboard
Jul 24, 2021
Merged

bpo-44353: Document that typing.NewType is now a class#27319
ambv merged 2 commits into
python:mainpython/cpython:mainfrom
Fidget-Spinner:newtype_docsFidget-Spinner/cpython:newtype_docsCopy head branch name to clipboard

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Jul 24, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Jul 24, 2021
@Fidget-Spinner

Fidget-Spinner commented Jul 24, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

Paging DJ @JelleZijlstra and emcee @ambv for a review on my new single please.

@ambv ambv merged commit 7aac3f6 into python:main Jul 24, 2021
@bedevere-bot

bedevere-bot commented Jul 24, 2021

Copy link
Copy Markdown

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

miss-islington commented Jul 24, 2021

Copy link
Copy Markdown
Contributor

Thanks @Fidget-Spinner for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jul 24, 2021

Copy link
Copy Markdown
Contributor

Sorry @Fidget-Spinner and @ambv, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 7aac3f623610cf3dffbf548a5be5bfd4fa6790a0 3.10

sthagen added a commit to sthagen/python-cpython that referenced this pull request Jul 24, 2021
@sthagen
Merge pull request #559 from python/main
c28520c 
bpo-44353: Document that typing.NewType is now a class (python#27319)
@ambv ambv added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Jul 24, 2021
@miss-islington

miss-islington commented Jul 24, 2021

Copy link
Copy Markdown
Contributor

Thanks @Fidget-Spinner for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 24, 2021
@Fidget-Spinner @miss-islington
bpo-44353: Document that typing.NewType is now a class (pythonGH-27319)
f073838 
(cherry picked from commit 7aac3f6)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Jul 24, 2021

Copy link
Copy Markdown

GH-27321 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 24, 2021
@Fidget-Spinner Fidget-Spinner deleted the newtype_docs branch July 24, 2021 09:02
ambv pushed a commit that referenced this pull request Jul 24, 2021
@miss-islington @Fidget-Spinner
bpo-44353: Document that typing.NewType is now a class (GH-27319) (GH…
d15949a 
…-27321)

(cherry picked from commit 7aac3f6)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

@ambv ambv

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Fidget-Spinner @bedevere-bot @miss-islington @ambv @the-knights-who-say-ni
Morty Proxy This is a proxified and sanitized view of the page, visit original site.