Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

bpo-44353: Add test to cover __or__ of two typing.NewType#27259

Merged
ambv merged 1 commit into
python:mainpython/cpython:mainfrom
uriyyo:fix-issue-44353uriyyo/cpython:fix-issue-44353Copy head branch name to clipboard
Jul 20, 2021
Merged

bpo-44353: Add test to cover __or__ of two typing.NewType#27259
ambv merged 1 commit into
python:mainpython/cpython:mainfrom
uriyyo:fix-issue-44353uriyyo/cpython:fix-issue-44353Copy head branch name to clipboard

Conversation

@uriyyo

@uriyyo uriyyo commented Jul 20, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@uriyyo uriyyo requested a review from gvanrossum as a code owner July 20, 2021 13:34
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Jul 20, 2021
@uriyyo

uriyyo commented Jul 20, 2021

Copy link
Copy Markdown
Member Author

@Fidget-Spinner Could you please review this PR and add skip-news label?

Fidget-Spinner
Fidget-Spinner approved these changes Jul 20, 2021
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment •
edited by ambv
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

PS: To whoever merges this. This needs GH-27258 to be merged first before backporting.

@ambv ambv merged commit 4868b94 into python:main Jul 20, 2021
@bedevere-bot

bedevere-bot commented Jul 20, 2021

Copy link
Copy Markdown

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

miss-islington commented Jul 20, 2021

Copy link
Copy Markdown
Contributor

Thanks @uriyyo for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jul 20, 2021

Copy link
Copy Markdown
Contributor

Sorry, @uriyyo and @ambv, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4868b94c6089d457673b1ba5b5b64c2f38c435af 3.10

@Fidget-Spinner

Fidget-Spinner commented Jul 20, 2021

Copy link
Copy Markdown
Member

Cherry picker isn't needed, just needs GH-27250. I will re-add the label when that lands.

@ambv ambv added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Jul 20, 2021
@miss-islington

miss-islington commented Jul 20, 2021

Copy link
Copy Markdown
Contributor

Thanks @uriyyo for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jul 20, 2021

Copy link
Copy Markdown
Contributor

Sorry @uriyyo and @ambv, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 4868b94c6089d457673b1ba5b5b64c2f38c435af 3.10

@ambv ambv added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Jul 20, 2021
@miss-islington

miss-islington commented Jul 20, 2021

Copy link
Copy Markdown
Contributor

Thanks @uriyyo for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 20, 2021
@bedevere-bot

bedevere-bot commented Jul 20, 2021

Copy link
Copy Markdown

GH-27261 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2021
@uriyyo @miss-islington
bpo-44353: Add test to cover __or__ of two NewType (pythonGH-27259)
d158d6a 
(cherry picked from commit 4868b94)

Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
ambv pushed a commit that referenced this pull request Jul 20, 2021
@miss-islington @uriyyo
bpo-44353: Add test to cover __or__ of two NewType (GH-27259) (#27261)
9ae5ba7 
(cherry picked from commit 4868b94)

Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

@ambv ambv

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@uriyyo @bedevere-bot @miss-islington @Fidget-Spinner @ambv @the-knights-who-say-ni
Morty Proxy This is a proxified and sanitized view of the page, visit original site.