Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

bpo-44490: Add 'Whats New' docs regarding types.Union changes#27215

Merged
ambv merged 4 commits into
python:mainpython/cpython:mainfrom
uriyyo:docs-44490uriyyo/cpython:docs-44490Copy head branch name to clipboard
Jul 26, 2021
Merged

bpo-44490: Add 'Whats New' docs regarding types.Union changes#27215
ambv merged 4 commits into
python:mainpython/cpython:mainfrom
uriyyo:docs-44490uriyyo/cpython:docs-44490Copy head branch name to clipboard

Conversation

@uriyyo

@uriyyo uriyyo commented Jul 17, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Jul 17, 2021
@uriyyo

uriyyo commented Jul 17, 2021

Copy link
Copy Markdown
Member Author

@Fidget-Spinner Could you please review What's new? I believe you can improve what I wrote)

And also, could you please add skip-news label?

@Fidget-Spinner

Fidget-Spinner commented Jul 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

I'm really sorry, but Serhiy may be backporting the change to 3.10. In which case we won't need to add a whats new for 3.11.

If his backport lands, please instead add your name to the whats new in 3.10 https://docs.python.org/3.10/whatsnew/3.10.html#pep-604-new-type-union-operator. (the part mentioning Maggie and Phillipe). I think you've earned it :).

@uriyyo

uriyyo commented Jul 17, 2021

Copy link
Copy Markdown
Member Author

Okay, thats makes sense. Let's wait for Serhiy changes.

@Fidget-Spinner

Fidget-Spinner commented Jul 18, 2021

Copy link
Copy Markdown
Member

Ok, Serhiy has landed his 3.10 backports so we don't need the what's new in 3.11 anymore. Please credit him and yourself in the 3.10 whats new. Maybe (Contributed by Maggie Moss and Philippe Prados in :issue:`41428`, with additions by Yurii Karabas and Serhiy Storchaka in :issue:`44490`.)?

@Fidget-Spinner Fidget-Spinner added the needs backport to 3.10 only security fixes label Jul 19, 2021
@ambv ambv merged commit 6c1b57d into python:main Jul 26, 2021
@miss-islington

miss-islington commented Jul 26, 2021

Copy link
Copy Markdown
Contributor

Thanks @uriyyo for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jul 26, 2021

Copy link
Copy Markdown

GH-27368 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 26, 2021
@uriyyo @miss-islington
bpo-44490: Add 'Whats New' docs regarding types.Union changes (python…
e5552d8 
…GH-27215)

(cherry picked from commit 6c1b57d)

Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
ambv pushed a commit that referenced this pull request Jul 26, 2021
@miss-islington @uriyyo
bpo-44490: Add 'Whats New' docs regarding types.Union changes (GH-27215…
4a5457d 
…) (GH-27368)

(cherry picked from commit 6c1b57d)

Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@uriyyo @Fidget-Spinner @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni
Morty Proxy This is a proxified and sanitized view of the page, visit original site.