[bpo-30916] Pre-build OpenSSL and Tcl/Tk for Windows#2688
[bpo-30916] Pre-build OpenSSL and Tcl/Tk for Windows#2688
Conversation
Updates build files to use find_python.bat Updates ssl and tkinter projects to use pre-built externals
Ensure prepared builds can be signed Fix download options Update installer
|
@zooba, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zware, @segevfiner and @briancurtin to be potential reviewers. |
Prefer MSBuild 14.0 over 15.0 in case the latter is missing install files.
|
See the binary builds at https://github.com/zooba/cpython-bin-deps/tree/tcltk-8.6.6.0 and https://github.com/zooba/cpython-bin-deps/tree/openssl-bin-1.0.2k. You can do a test build by running |
Remove stray parenthesis
Prepare scripts copy licenses into bin folder and installer picks them up from the right place
Simplifies prepare_ssl.py
|
I have successful builds and test runs now when pulling externals from my repo. If there are no suggestions about the layout of the binaries repo, then I'll push release-ready builds to them so the CI build passes. |
|
Zach opted not to review right now and said go ahead and he'll fix up my failures later :) I pushed release bits to our actual repository and triggered another build (hopefully) to test. |
|
Build passes fine with the binaries published. Detailed comment on the bug |
Not ready to merge yet, but far enough along for @zware and any interested parties to take a look.
Before finally merging this, I'll do releasable/signed builds and upload them to the GitHub repository, which should make the CI pass.
The change to OpenSSL cannot be backported, in my opinion (unless we prove that it is totally safe). While the Tcl/Tk change can be, I'm not sure that it's worth it.