Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.10] bpo-43795: Don't list private names in the limited API (GH-26740)#26753

Merged
miss-islington merged 1 commit into
python:3.10python/cpython:3.10from
miss-islington:backport-7cad9cb-3.10miss-islington/cpython:backport-7cad9cb-3.10Copy head branch name to clipboard
Jun 16, 2021
Merged

[3.10] bpo-43795: Don't list private names in the limited API (GH-26740)#26753
miss-islington merged 1 commit into
python:3.10python/cpython:3.10from
miss-islington:backport-7cad9cb-3.10miss-islington/cpython:backport-7cad9cb-3.10Copy head branch name to clipboard

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 16, 2021

Copy link
Copy Markdown
Contributor
  • Use the public alias PyFrameObject rather than _frame
  • Remove _node, which disappeared in 3.9 along with the old parser
  • Ensure private (underscore-prefixed) names are not on the Limited API list. (They can be part of the stable ABI, though, e.g. as implementation details of macros.)

(cherry picked from commit 7cad9cb)

Co-authored-by: Petr Viktorin encukou@gmail.com

https://bugs.python.org/issue43795

* Remove struct _node from the stable ABI list

This struct was removed along with the old parser in Python 3.9 (PEP 617)

* Stable ABI list: Use the public name "PyFrameObject" rather than "_frame"

* Ensure limited API doesn't contain private names

Names prefixed by an underscore are private by definition.

* Add a blurb
(cherry picked from commit 7cad9cb)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a success ✅ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a success ✅ .

@encukou

encukou commented Jun 16, 2021

Copy link
Copy Markdown
Member

cc @pablogsal – stable ABI doc fix & additional check

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.