Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-44087: Disallow instantiation of sqlite3.Statement#26567

Merged
pablogsal merged 3 commits into
python:mainpython/cpython:mainfrom
erlend-aasland:sqlite-disallow-stmt-insterlend-aasland/cpython:sqlite-disallow-stmt-instCopy head branch name to clipboard
Jun 20, 2021
Merged

bpo-44087: Disallow instantiation of sqlite3.Statement#26567
pablogsal merged 3 commits into
python:mainpython/cpython:mainfrom
erlend-aasland:sqlite-disallow-stmt-insterlend-aasland/cpython:sqlite-disallow-stmt-instCopy head branch name to clipboard

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jun 6, 2021

Copy link
Copy Markdown
Contributor

The sqlite3.Statement type is not exposed, but it is possible to fetch it via the
sqlite3.Connection object. The statement type is an implementation detail; it
should not be possible to instantiate statement objects.

https://bugs.python.org/issue44087

@pablogsal pablogsal merged commit 7d0a47e into python:main Jun 20, 2021
@pablogsal pablogsal added the needs backport to 3.10 only security fixes label Jun 20, 2021
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 20, 2021
(cherry picked from commit 7d0a47e)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 20, 2021
@bedevere-bot

Copy link
Copy Markdown

GH-26813 is a backport of this pull request to the 3.10 branch.

@erlend-aasland erlend-aasland deleted the sqlite-disallow-stmt-inst branch June 20, 2021 20:32
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jun 20, 2021
…GH-26567)

(cherry picked from commit 7d0a47e)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
pablogsal pushed a commit that referenced this pull request Jun 20, 2021
) (GH-26816)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.