bpo-42213: Check connection in sqlite3.Connection.__enter__#26512
Merged
vstinner merged 2 commits intoJun 3, 2021
python:mainpython/cpython:mainfrom
erlend-aasland:sqlite-improve-closeerlend-aasland/cpython:sqlite-improve-closeCopy head branch name to clipboard
Merged
bpo-42213: Check connection in sqlite3.Connection.__enter__#26512vstinner merged 2 commits intopython:mainpython/cpython:mainfrom erlend-aasland:sqlite-improve-closeerlend-aasland/cpython:sqlite-improve-closeCopy head branch name to clipboard
vstinner merged 2 commits into
python:mainpython/cpython:mainfrom
erlend-aasland:sqlite-improve-closeerlend-aasland/cpython:sqlite-improve-closeCopy head branch name to clipboard
Conversation
- add tests that exercise stuff against a closed database - add wrapper for sqlite3_close_v2() - check connection on __enter__ - explicitly free pending statements before close() - sqlite3_close_v2() always returns SQLITE_OK
Contributor
Author
|
Ref. #26462 (comment) |
vstinner
reviewed
Jun 3, 2021
Member
|
Merged, this change is atomic and remains useful, thanks! |
Contributor
Author
|
Thanks for reviewing, Victor! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__enter__https://bugs.python.org/issue42213