bpo-30886: Fix multiprocessing.Queue.join_thread()#2642
Merged
vstinner merged 1 commit intoJul 10, 2017
python:masterpython/cpython:masterfrom
vstinner:mp_queue_join_threadCopy head branch name to clipboard
Merged
bpo-30886: Fix multiprocessing.Queue.join_thread()#2642vstinner merged 1 commit intopython:masterpython/cpython:masterfrom vstinner:mp_queue_join_threadCopy head branch name to clipboard
vstinner merged 1 commit into
python:masterpython/cpython:masterfrom
vstinner:mp_queue_join_threadCopy head branch name to clipboard
Conversation
|
@Haypo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @cf-natali and @shibturn to be potential reviewers. |
Member
Author
|
Sorry, I don't understand well the purpose of created_by_this_process, so I didn't write a proper commit message yet. |
pitrou
requested changes
Jul 10, 2017
pitrou
left a comment
Member
There was a problem hiding this comment.
This needs a NEWS blurb, otherwise looks ok to me.
multiprocessing.Queue.join_thread() now waits until the thread completes, even if the thread was started by the same process which created the queue. Fix the following warning which occurs randomly when running test_handle_called_with_mp_queue of test_logging.QueueListenerTest: Warning -- threading_cleanup() failed to cleanup -1 threads after 4 sec (count: 0, dangling: 1)
Member
Author
Ok, done. |
pitrou
approved these changes
Jul 10, 2017
|
GH-2643 is a backport of this pull request to the 3.6 branch. |
|
GH-2644 is a backport of this pull request to the 3.5 branch. |
vstinner
added a commit
that referenced
this pull request
Jul 10, 2017
multiprocessing.Queue.join_thread() now waits until the thread completes, even if the thread was started by the same process which created the queue. Fix the following warning which occurs randomly when running test_handle_called_with_mp_queue of test_logging.QueueListenerTest: Warning -- threading_cleanup() failed to cleanup -1 threads after 4 sec (count: 0, dangling: 1) (cherry picked from commit 3b69d91)
vstinner
added a commit
that referenced
this pull request
Jul 10, 2017
multiprocessing.Queue.join_thread() now waits until the thread completes, even if the thread was started by the same process which created the queue. Fix the following warning which occurs randomly when running test_handle_called_with_mp_queue of test_logging.QueueListenerTest: Warning -- threading_cleanup() failed to cleanup -1 threads after 4 sec (count: 0, dangling: 1) (cherry picked from commit 3b69d91)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multiprocessing.Queue.join_thread() now waits until the thread
completes, even if the thread was started by the same process which
created the queue.
Fix the following warning which occurs randomly when running
test_handle_called_with_mp_queue of test_logging.QueueListenerTest:
Warning -- threading_cleanup() failed to cleanup -1 threads after 4 sec (count: 0, dangling: 1)