Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-43916: Use test.support.check_disallow_instantiation in test_tcl#26412

Merged
vstinner merged 1 commit into
python:mainpython/cpython:mainfrom
erlend-aasland:fixup-old-inst-testserlend-aasland/cpython:fixup-old-inst-testsCopy head branch name to clipboard
May 27, 2021
Merged

bpo-43916: Use test.support.check_disallow_instantiation in test_tcl#26412
vstinner merged 1 commit into
python:mainpython/cpython:mainfrom
erlend-aasland:fixup-old-inst-testserlend-aasland/cpython:fixup-old-inst-testsCopy head branch name to clipboard

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 27, 2021

Copy link
Copy Markdown
Contributor

@erlend-aasland erlend-aasland requested a review from vstinner May 27, 2021 18:08
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label May 27, 2021
@erlend-aasland erlend-aasland added needs backport to 3.10 only security fixes skip news and removed needs backport to 3.10 only security fixes labels May 27, 2021
@erlend-aasland

Copy link
Copy Markdown
Contributor Author

From issue 43988:

Serhiy suggested to write an unit test for curses.ncurses_version:
> https://bugs.python.org/issue43916#msg391936

Excerpt from msg391936:

I think it is better to add tests for different modules in corresponding module test files. They are pretty trivial, for example:

    def test_new_tcl_obj(self):
        self.assertRaises(TypeError, _tkinter.Tcl_Obj)

    @requires_curses_func('panel')
    def test_new_curses_panel(self):
        w = curses.newwin(10, 10)
        panel = curses.panel.new_panel(w)
        self.assertRaises(TypeError, type(panel))

test_new_curses_panel was added in GH-25748 and then converted to use the support helper in GH-26392.

I'm not sure if it makes sense to add a test for curses.ncurses_version.

@vstinner vstinner merged commit e90e042 into python:main May 27, 2021
@vstinner

Copy link
Copy Markdown
Member

Merged, thanks.

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2021
pythonGH-26412)

(cherry picked from commit e90e042)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot

Copy link
Copy Markdown

GH-26888 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 24, 2021
vstinner pushed a commit that referenced this pull request Jun 24, 2021
GH-26412) (GH-26888)

(cherry picked from commit e90e042)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.