[3.6] bpo-30779: IDLE -- Factor ConfigChanges class from configdialog…#2625
Merged
terryjreedy merged 1 commit intoJul 7, 2017
python:3.6python/cpython:3.6from
terryjreedy:backport-349abd9-3.6terryjreedy/cpython:backport-349abd9-3.6Copy head branch name to clipboard
Merged
[3.6] bpo-30779: IDLE -- Factor ConfigChanges class from configdialog…#2625terryjreedy merged 1 commit intopython:3.6python/cpython:3.6from terryjreedy:backport-349abd9-3.6terryjreedy/cpython:backport-349abd9-3.6Copy head branch name to clipboard
terryjreedy merged 1 commit into
python:3.6python/cpython:3.6from
terryjreedy:backport-349abd9-3.6terryjreedy/cpython:backport-349abd9-3.6Copy head branch name to clipboard
Conversation
…, put in config; test. (pythonGH-2612) * In config, put dump test code in a function; run it and unittest in 'if __name__ == '__main__'. * Add class config.ConfigChanges based on changes_class_v4.py on bpo issue. * Add class test_config.ChangesTest, partly based on configdialog_tests_v1.py on bpo issue. * Revise configdialog to use ConfigChanges, mostly as specified in tracker msg297804. * Revise test_configdialog to match configdialog changes. All tests pass in both files. * Remove configdialog functions unused or moved to ConfigChanges. Cheryl Sabella contributed parts of the patch. (cherry picked from commit 349abd9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…, put in config; test. (GH-2612)
Cheryl Sabella contributed parts of the patch.
(cherry picked from commit 349abd9)