Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-44131: Py_FrozenMain() uses PyConfig_SetBytesArgv()#26201

Merged
vstinner merged 1 commit into
python:mainpython/cpython:mainfrom
vstinner:frozenmain_argvCopy head branch name to clipboard
May 20, 2021
Merged

bpo-44131: Py_FrozenMain() uses PyConfig_SetBytesArgv()#26201
vstinner merged 1 commit into
python:mainpython/cpython:mainfrom
vstinner:frozenmain_argvCopy head branch name to clipboard

Conversation

@vstinner

@vstinner vstinner commented May 17, 2021

Copy link
Copy Markdown
Member

Moreover, Py_FrozenMain() relies on Py_InitializeFromConfig() to
handle the PYTHONUNBUFFERED environment variable and configure C
stdio streams like stdout (make the stream unbuffered).

https://bugs.python.org/issue44131

@vstinner

Copy link
Copy Markdown
Member Author

@corona10: Would you mind to review this change?

@corona10 corona10 self-requested a review May 17, 2021 23:45
Moreover, Py_FrozenMain() relies on Py_InitializeFromConfig() to
handle the PYTHONUNBUFFERED environment variable and configure C
stdio streams like stdout (make the stream unbuffered).
@vstinner

Copy link
Copy Markdown
Member Author

PR rebased on top of commit 6ba6d06 fix.

@corona10

Copy link
Copy Markdown
Member

@vstinner I will review this PR tonight :)

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vstinner vstinner merged commit 58a9939 into python:main May 20, 2021
@vstinner vstinner deleted the frozenmain_argv branch May 20, 2021 10:08
@vstinner

Copy link
Copy Markdown
Member Author

Thanks for the review @corona10.

It's a pleasure to remove code which calls directly Py_DecodeLocale() without preinitializing Python :-p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.