[3.10] bpo-37788: Fix reference leak when Thread is never joined (GH-26103)#26138
Merged
miss-islington merged 1 commit intoMay 15, 2021
python:3.10python/cpython:3.10from
miss-islington:backport-c10c2ec-3.10miss-islington/cpython:backport-c10c2ec-3.10Copy head branch name to clipboard
Merged
[3.10] bpo-37788: Fix reference leak when Thread is never joined (GH-26103)#26138miss-islington merged 1 commit intopython:3.10python/cpython:3.10from miss-islington:backport-c10c2ec-3.10miss-islington/cpython:backport-c10c2ec-3.10Copy head branch name to clipboard
miss-islington merged 1 commit into
python:3.10python/cpython:3.10from
miss-islington:backport-c10c2ec-3.10miss-islington/cpython:backport-c10c2ec-3.10Copy head branch name to clipboard
Conversation
…6103) When a Thread is not joined after it has stopped, its lock may remain in the _shutdown_locks set until interpreter shutdown. If many threads are created this way, the _shutdown_locks set could therefore grow endlessly. To avoid such a situation, purge expired locks each time a new one is added or removed. (cherry picked from commit c10c2ec) Co-authored-by: Antoine Pitrou <antoine@python.org>
Contributor
Author
|
@pitrou: Status check is done, and it's a success ✅ . |
2 similar comments
Contributor
Author
|
@pitrou: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@pitrou: Status check is done, and it's a success ✅ . |
Contributor
Author
|
Sorry, I can't merge this PR. Reason: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Thread is not joined after it has stopped, its lock may remain in the _shutdown_locks set until interpreter shutdown. If many threads are created this way, the _shutdown_locks set could therefore grow endlessly. To avoid such a situation, purge expired locks each time a new one is added or removed.
(cherry picked from commit c10c2ec)
Co-authored-by: Antoine Pitrou antoine@python.org
https://bugs.python.org/issue37788
Automerge-Triggered-By: GH:pitrou