bpo-40943: Fix skipitem() didn't raise SystemError#25937
Merged
Merged
bpo-40943: Fix skipitem() didn't raise SystemError#25937
Conversation
convertitem() raises SystemError when # is used PY_SSIZE_T_CLEAN. skipitem() should too.
serhiy-storchaka
approved these changes
May 6, 2021
| return NULL; | ||
| } | ||
| (void) va_arg(*p_va, int *); | ||
| PyErr_SetString(PyExc_SystemError, |
Member
There was a problem hiding this comment.
I would rewrite this code in the form:
if (!(flags & FLAG_SIZE_T)) {
...
}
(void) va_arg(*p_va, Py_ssize_t *);
Contributor
|
Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-25961 is a backport of this pull request to the 3.10 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convertitem()raises SystemError when '#' is used withoutPY_SSIZE_T_CLEANdefined.skipitem()should do it too.https://bugs.python.org/issue40943