bpo-43892: Validate the first term of complex literal value patterns#25735
Merged
brandtbucher merged 7 commits intoApr 30, 2021
python:masterpython/cpython:masterfrom
brandtbucher:patma-parser-cleanupbrandtbucher/cpython:patma-parser-cleanupCopy head branch name to clipboard
Merged
bpo-43892: Validate the first term of complex literal value patterns#25735brandtbucher merged 7 commits intopython:masterpython/cpython:masterfrom brandtbucher:patma-parser-cleanupbrandtbucher/cpython:patma-parser-cleanupCopy head branch name to clipboard
brandtbucher merged 7 commits into
python:masterpython/cpython:masterfrom
brandtbucher:patma-parser-cleanupbrandtbucher/cpython:patma-parser-cleanupCopy head branch name to clipboard
Conversation
pablogsal
approved these changes
Apr 29, 2021
pablogsal
left a comment
Member
There was a problem hiding this comment.
LGTM
I checked also for refleaks (although this really doesn't add any new paths were we can leak):
❯ ./python -m test test_patma test_compile test_ast -R :
0:00:00 load avg: 1.71 Run tests sequentially
0:00:00 load avg: 1.71 [1/3] test_patma
beginning 9 repetitions
123456789
.........
0:00:00 load avg: 1.71 [2/3] test_compile
beginning 9 repetitions
123456789
.........
0:00:38 load avg: 1.40 [3/3] test_ast -- test_compile passed in 38.2 sec
beginning 9 repetitions
123456789
.........
== Tests result: SUCCESS ==
All 3 tests OK.
Total duration: 1 min 1 sec
Tests result: SUCCESS
Member
|
Thanks for the cleanup, @brandtbucher ! 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes validation of complex literal value patterns in the parser and factors out the old
compiler_pattern_captureandcompiler_pattern_wildcardroutines to better match the current AST.(A few other cleanups, too.)
https://bugs.python.org/issue43892