[2.7] bpo-30759: Fix test_multibytecodec_support#2545
Closed
vstinner wants to merge 1 commit into
Closed
Conversation
TestBase_Mapping doesn't inherit from unittest.TestCase anymore, but object, since it's not a real test case but only a base base. All child classes already inherit from unittest.TestCase.
Member
Author
|
Example: test_codecmaps_tw still runs the same 6 tests with this change. |
Member
|
Yes, this works. But maybe make the tests more similar to 3.x and just rename |
Member
|
See 75d9aca. |
Member
|
Backported in #2548. |
Member
Author
|
Abandonned in favor of @serhiy-storchaka PR #2548. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestBase_Mapping doesn't inherit from unittest.TestCase anymore, but
object, since it's not a real test case but only a base base. All
child classes already inherit from unittest.TestCase.