[3.9] bpo-43710: Rollback the 3.9 bpo-42500 fix, it broke the ABI in 3.9.3#25179
Merged
ambv merged 2 commits intoApr 4, 2021
python:3.9python/cpython:3.9from
gpshead:rollback-bpo-42500-it-broke-393gpshead/cpython:rollback-bpo-42500-it-broke-393Copy head branch name to clipboard
Merged
[3.9] bpo-43710: Rollback the 3.9 bpo-42500 fix, it broke the ABI in 3.9.3#25179ambv merged 2 commits intopython:3.9python/cpython:3.9from gpshead:rollback-bpo-42500-it-broke-393gpshead/cpython:rollback-bpo-42500-it-broke-393Copy head branch name to clipboard
ambv merged 2 commits into
python:3.9python/cpython:3.9from
gpshead:rollback-bpo-42500-it-broke-393gpshead/cpython:rollback-bpo-42500-it-broke-393Copy head branch name to clipboard
Conversation
…nGH-23568) (python#24501)" This reverts commit 8b795ab. It changed the PyThreadState structure size, breaking the ABI in 3.9.3.
|
@ambv: Please replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix for https://bugs.python.org/issue42500 included in 3.9.3 broke the ABI, leading to https://bugs.python.org/issue43710.
This PR is a rollback (git revert) of the specific change 8b795ab that caused the problem.
I suggest doing this for a perfectly safe 3.9.4 rather than trying to redo the non-critical bugfix under duress as a rush over a significant portion of the worlds holiday. Fixing it properly can wait until a scheduled 3.9.5.
https://bugs.python.org/issue43710