bpo-43510: Fix emitting EncodingWarning from _io module.#25146
Merged
methane merged 1 commit intoApr 2, 2021
python:masterpython/cpython:masterfrom
methane:fix-textio-encodingwarningmethane/cpython:fix-textio-encodingwarningCopy head branch name to clipboard
Merged
bpo-43510: Fix emitting EncodingWarning from _io module.#25146methane merged 1 commit intopython:masterpython/cpython:masterfrom methane:fix-textio-encodingwarningmethane/cpython:fix-textio-encodingwarningCopy head branch name to clipboard
methane merged 1 commit into
python:masterpython/cpython:masterfrom
methane:fix-textio-encodingwarningmethane/cpython:fix-textio-encodingwarningCopy head branch name to clipboard
Conversation
I forget to check PyErr_WarnEx() return value. But it will fail when -Werror is used.
vstinner
approved these changes
Apr 2, 2021
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. I didn't test your change.
sthagen
added a commit
to sthagen/python-cpython
that referenced
this pull request
Apr 2, 2021
bpo-43510: Fix emitting EncodingWarning from _io module. (pythonGH-25146)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forget to check PyErr_WarnEx() return value. But it will fail when -Werror is used.
https://bugs.python.org/issue43510