bpo-43612: Add wbits parameter to zlib.compress#25011
Closed
rhpvorderman wants to merge 10 commits into
Closed
bpo-43612: Add wbits parameter to zlib.compress#25011rhpvorderman wants to merge 10 commits into
rhpvorderman wants to merge 10 commits into
Conversation
|
This PR is stale because it has been open for 30 days with no activity. |
Contributor
Author
|
@ZackerySpytz Thank you for the review! I addressed your comments. |
Contributor
Author
|
Changes incorporated in #27941 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to compress raw deflate blocks without zlib headers and trailers in one go. Without needing to use zlib.compressobj. Also this allows users to do
zlib.compress(data, 1, wbits=31)which is much faster thangzip.compress(data, 1).https://bugs.python.org/issue43612