Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-43244: GitHub Action builds Python in debug mode on Windows#24914

Closed
vstinner wants to merge 1 commit into
python:masterpython/cpython:masterfrom
vstinner:gha_win_debugCopy head branch name to clipboard
Closed

bpo-43244: GitHub Action builds Python in debug mode on Windows#24914
vstinner wants to merge 1 commit into
python:masterpython/cpython:masterfrom
vstinner:gha_win_debugCopy head branch name to clipboard

Conversation

@vstinner

@vstinner vstinner commented Mar 18, 2021

Copy link
Copy Markdown
Member

The debug mode catchs more bugs but is slower.

https://bugs.python.org/issue43244

@vstinner

Copy link
Copy Markdown
Member Author

cc @zooba @zware @pablogsal

I didn't check yet if this change makes the CI way slower or not.

I wrote this PR since the Windows x64 job of GitHub Actions didn't catch the build error about Py_DebugFlag in test_peg_generator in my previous PR:
#24912 (comment)

Hopefully, we have at least one Windows buildbot running in release mode: https://buildbot.python.org/all/#/builders/405

The debug mode catchs more bugs but is slower.
@vstinner

Copy link
Copy Markdown
Member Author

Oh, test_peg_generator failed. I rebased my PR on top of my commit 57d0a87 fix.

test_locale also fails, I don't know why and I don't see why it only fails in debug mode:

ERROR: test_getsetlocale_issue1813 (test.test_locale.TestMiscellaneous)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\lib\test\test_locale.py", line 567, in test_getsetlocale_issue1813
    locale.setlocale(locale.LC_CTYPE, loc)
  File "D:\a\cpython\cpython\lib\locale.py", line 610, in setlocale
    return _setlocale(category, locale)
locale.Error: unsupported locale setting

@vstinner

Copy link
Copy Markdown
Member Author

The job still fails with:

ERROR: test_getsetlocale_issue1813 (test.test_locale.TestMiscellaneous)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\lib\test\test_locale.py", line 567, in test_getsetlocale_issue1813
    locale.setlocale(locale.LC_CTYPE, loc)
  File "D:\a\cpython\cpython\lib\locale.py", line 610, in setlocale
    return _setlocale(category, locale)
locale.Error: unsupported locale setting

With test_locale re-run in verbose mode, "the total tests duration is 19 min 41 sec.

@vstinner

Copy link
Copy Markdown
Member Author

Oh, test_locale failure seems to be known since 2019: https://bugs.python.org/issue37945

@vstinner

Copy link
Copy Markdown
Member Author

Without this PR (Python built in release mode), tests take 12 min 19 sec on Windows x64. It should be compared with 19 min 41 sec with this PR. So this PR adds 7 minutes to the CI, it's quite signifiant (1.6x slower).

I'm not sure that I would like to make the CI slower on all PRs just because once per year there is a bug not catched by the pre-commit PR. I close the PR.

@vstinner vstinner closed this Mar 18, 2021
@vstinner vstinner deleted the gha_win_debug branch March 18, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.