bpo-43381: Add frozen module co_lines() test#24712
Closed
nascheme wants to merge 2 commits into
Closed
bpo-43381: Add frozen module co_lines() test#24712nascheme wants to merge 2 commits into
nascheme wants to merge 2 commits into
Conversation
Member
Author
|
This PR will fail until |
|
This PR is stale because it has been open for 30 days with no activity. |
akulakov
reviewed
Jul 5, 2021
| name = '__hello__' | ||
| if name in sys.modules: | ||
| del sys.modules[name] | ||
| # Invalid marshalled data in frozen.c could case the interpreter to |
akulakov
reviewed
Jul 5, 2021
| import __hello__ | ||
| self.assertEqual(out.getvalue(), 'Hello world!\n') | ||
|
|
||
| @impl_detail('code object line table', cpython=True) |
Contributor
There was a problem hiding this comment.
a small nitpick: cpython arg is not needed and other uses of @impl_detail in tests leave it out (with just one exception).
iritkatriel
requested changes
Nov 27, 2022
iritkatriel
left a comment
Member
There was a problem hiding this comment.
This has merge conflicts now.
|
When you're done making the requested changes, leave the comment: |
Member
Author
|
This PR seems obsolete now since Eric Snow added some tests to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue43381