Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

bpo-42128: Add Pattern Matching to What's New#24667

Merged
willingc merged 5 commits into
python:masterpython/cpython:masterfrom
willingc:patternswillingc/cpython:patternsCopy head branch name to clipboard
Feb 28, 2021
Merged

bpo-42128: Add Pattern Matching to What's New#24667
willingc merged 5 commits into
python:masterpython/cpython:masterfrom
willingc:patternswillingc/cpython:patternsCopy head branch name to clipboard

Conversation

@willingc

@willingc willingc commented Feb 28, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Feb 28, 2021
@willingc

willingc commented Feb 28, 2021

Copy link
Copy Markdown
Contributor Author

@ramalho If you get a chance, please take a look. Thanks!

gvanrossum
gvanrossum reviewed Feb 28, 2021
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much Carol! I found a few markup mistakes and have a few more editorial suggestions.

Comment thread Doc/whatsnew/3.10.rst Outdated
Comment thread Doc/whatsnew/3.10.rst Outdated
Comment thread Doc/whatsnew/3.10.rst Outdated
Comment thread Doc/whatsnew/3.10.rst Outdated
Comment thread Doc/whatsnew/3.10.rst Outdated
Comment thread Doc/whatsnew/3.10.rst Outdated
Comment thread Doc/whatsnew/3.10.rst Outdated
Comment thread Doc/whatsnew/3.10.rst
Comment thread Doc/whatsnew/3.10.rst Outdated
Comment thread Doc/whatsnew/3.10.rst Outdated
gvanrossum
gvanrossum reviewed Feb 28, 2021
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hit Submit too soon, here are the last three review items. Goodnight!

Comment thread Doc/whatsnew/3.10.rst Outdated
Comment thread Doc/whatsnew/3.10.rst Outdated
Comment thread Doc/whatsnew/3.10.rst
Fidget-Spinner
Fidget-Spinner reviewed Feb 28, 2021
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't read everything in detail, but here's a bunch of suggestions to get the CI checks to pass :).
(mostly just whitespace fixes)

Comment thread Doc/whatsnew/3.10.rst Outdated
Comment thread Doc/whatsnew/3.10.rst Outdated
Comment thread Doc/whatsnew/3.10.rst Outdated
Comment thread Doc/whatsnew/3.10.rst Outdated
Comment thread Doc/whatsnew/3.10.rst Outdated
KunKax
KunKax reviewed Feb 28, 2021
View reviewed changes

@KunKax KunKax left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

dmoisset
dmoisset reviewed Feb 28, 2021
View reviewed changes
Comment thread Doc/whatsnew/3.10.rst Outdated
gvanrossum
gvanrossum reviewed Feb 28, 2021
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on having Scala *and *Elixir.

Comment thread Doc/whatsnew/3.10.rst Outdated
Comment thread Doc/whatsnew/3.10.rst Outdated
@ramalho

ramalho commented Feb 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Great quick intro, @willingc thanks! I think the special variable _ deserves more attention. It appears only alone in the last case clause, and then appears again in a discussion of *. Adding an example where _ appears inside a more elaborate pattern without * would clarify the essential meaning of _. Something like ('error', code, _).

I think it would help readers if that example could appear after an example with case _, but before any mention of *.

Also, as @gvanrossum suggested, it's important to have an example without case _ to make it clear that no match means no op.

gvanrossum
gvanrossum approved these changes Feb 28, 2021
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@willingc

willingc commented Feb 28, 2021

Copy link
Copy Markdown
Contributor Author

Thanks @gvanrossum, @ramalho, and others who helped review this PR. Your feedback improved the content which should help users with understanding.

@gvanrossum

gvanrossum commented Feb 28, 2021

Copy link
Copy Markdown
Member

You're welcome! @willingc Go ahead and land it.

@willingc willingc merged commit 41934b3 into python:master Feb 28, 2021
@bedevere-bot

bedevere-bot commented Feb 28, 2021

Copy link
Copy Markdown

@willingc: Please replace # with GH- in the commit message next time. Thanks!

@willingc willingc deleted the patterns branch February 28, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner left review comments

@gvanrossum gvanrossum gvanrossum approved these changes

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

@pablogsal pablogsal Awaiting requested review from pablogsal

+2 more reviewers

@dmoisset dmoisset dmoisset left review comments

@KunKax KunKax KunKax left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@willingc @ramalho @gvanrossum @bedevere-bot @dmoisset @Fidget-Spinner @KunKax @the-knights-who-say-ni
Morty Proxy This is a proxified and sanitized view of the page, visit original site.