[3.5] bpo-30769: Fix reference leak introduced in 7770394 (GH-2416)#2447
Merged
vstinner merged 1 commit intoJun 27, 2017
python:3.5python/cpython:3.5from
emilyemorehouse:backport-a7874c7-3.5emilyemorehouse/cpython:backport-a7874c7-3.5Copy head branch name to clipboard
Merged
[3.5] bpo-30769: Fix reference leak introduced in 7770394 (GH-2416)#2447vstinner merged 1 commit intopython:3.5python/cpython:3.5from emilyemorehouse:backport-a7874c7-3.5emilyemorehouse/cpython:backport-a7874c7-3.5Copy head branch name to clipboard
vstinner merged 1 commit into
python:3.5python/cpython:3.5from
emilyemorehouse:backport-a7874c7-3.5emilyemorehouse/cpython:backport-a7874c7-3.5Copy head branch name to clipboard
Conversation
Member
Author
|
@Haypo A clean rebase allowed me to duplicate the original error on 3.5. I've confirmed that this now passes with the fix. |
vstinner
approved these changes
Jun 27, 2017
vstinner
left a comment
Member
There was a problem hiding this comment.
I confirm that "./python -m test -R 3:3 -m test_execve_invalid_env test_os" fails without the fix, and pass with the fix, thanks!
Member
|
Thanks @emilyemorehouse for the fix ;-) I merged your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.