Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-42988: Improve pydoc web server security#24285

Closed
Fidget-Spinner wants to merge 8 commits into
python:masterpython/cpython:masterfrom
Fidget-Spinner:pydoc-getfileFidget-Spinner/cpython:pydoc-getfileCopy head branch name to clipboard
Closed

bpo-42988: Improve pydoc web server security#24285
Fidget-Spinner wants to merge 8 commits into
python:masterpython/cpython:masterfrom
Fidget-Spinner:pydoc-getfileFidget-Spinner/cpython:pydoc-getfileCopy head branch name to clipboard

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Jan 21, 2021

Copy link
Copy Markdown
Member
  • Remove html_getfile.
  • Use locally generated secret to prevent other users from accessing a running web server.

EDIT: Honestly I'm not sure if we need to remove html_getfile now that there's a token to validate the user.

https://bugs.python.org/issue42988

Comment thread Lib/pydoc.py Outdated
@Fidget-Spinner Fidget-Spinner changed the title bpo-42988: Remove html_getfile operation from pydoc due to security concerns bpo-42988: Improve pydoc web server security Jan 22, 2021
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 26, 2021
Comment thread Lib/pydoc.py Outdated
@vstinner

Copy link
Copy Markdown
Member

I merged PR #25015 fix instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.