[3.6] bpo-30769: Fix reference leak introduced in 77703942c59 (GH-2416)#2425
Merged
serhiy-storchaka merged 1 commit intoJun 27, 2017
python:3.6python/cpython:3.6from
emilyemorehouse:backport-a7874c7-3.6emilyemorehouse/cpython:backport-a7874c7-3.6Copy head branch name to clipboard
Merged
[3.6] bpo-30769: Fix reference leak introduced in 77703942c59 (GH-2416)#2425serhiy-storchaka merged 1 commit intopython:3.6python/cpython:3.6from emilyemorehouse:backport-a7874c7-3.6emilyemorehouse/cpython:backport-a7874c7-3.6Copy head branch name to clipboard
serhiy-storchaka merged 1 commit into
python:3.6python/cpython:3.6from
emilyemorehouse:backport-a7874c7-3.6emilyemorehouse/cpython:backport-a7874c7-3.6Copy head branch name to clipboard
Conversation
) New error condition paths were introduced, which did not decrement `key2` and `val2` objects. Therefore, decrement references before jumping to the error label. Signed-off-by: Eric N. Vander Weele <ericvw@gmail.com> (cherry picked from commit a7874c7)
Member
|
@emilyemorehouse: Since there is no pre-commit CI for reference leaks, can you please confirm that the test leaks without the fix, and then pass with the fix? |
Member
Author
|
@Haypo tests fail with identical leaks pre-patch and indeed pass with this fix. |
serhiy-storchaka
approved these changes
Jun 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New error condition paths were introduced, which did not decrement
key2andval2objects. Therefore, decrement references beforejumping to the error label.
Signed-off-by: Eric N. Vander Weele ericvw@gmail.com
(cherry picked from commit a7874c7)