Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[2.7] bpo-30764: test_subprocess uses SuppressCrashReport (#2405)#2412

Merged
vstinner merged 2 commits into
python:2.7python/cpython:2.7from
vstinner:subprocess_stopped27Copy head branch name to clipboard
Jun 26, 2017
Merged

[2.7] bpo-30764: test_subprocess uses SuppressCrashReport (#2405)#2412
vstinner merged 2 commits into
python:2.7python/cpython:2.7from
vstinner:subprocess_stopped27Copy head branch name to clipboard

Conversation

@vstinner

Copy link
Copy Markdown
Member

Backport also test.support.SuppressCrashReport.

vstinner added 2 commits June 26, 2017 18:11
Backport test.support.SuppressCrashReport context-manager from
master. Drop the Windows implementation since it depends on
msvcrt.CrtSetReportMode() which isn't available on Python 2.7.
bpo-30764, bpo-29335: test_child_terminated_in_stopped_state() of
test_subprocess now uses support.SuppressCrashReport() to prevent the
creation of a core dump on FreeBSD.
(cherry picked from commit cdee3f1)
@vstinner

Copy link
Copy Markdown
Member Author

I backported the Windows implementation of test.support.SuppressCrashReport, but I prefer to write a separated PR for that, since it adds C code and so is very different from this change.

@vstinner vstinner changed the title bpo-30764: test_subprocess uses SuppressCrashReport (#2405) [2.7] bpo-30764: test_subprocess uses SuppressCrashReport (#2405) Jun 26, 2017
@vstinner vstinner merged commit 2097b9e into python:2.7 Jun 26, 2017
@vstinner vstinner deleted the subprocess_stopped27 branch June 26, 2017 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.