bpo-42721: Improve using simple dialogs without root window#23897
Merged
serhiy-storchaka merged 4 commits intoDec 25, 2020
python:masterpython/cpython:masterfrom
serhiy-storchaka:simple-common-dialog-temporary-rootserhiy-storchaka/cpython:simple-common-dialog-temporary-rootCopy head branch name to clipboard
Merged
bpo-42721: Improve using simple dialogs without root window#23897serhiy-storchaka merged 4 commits intopython:masterpython/cpython:masterfrom serhiy-storchaka:simple-common-dialog-temporary-rootserhiy-storchaka/cpython:simple-common-dialog-temporary-rootCopy head branch name to clipboard
serhiy-storchaka merged 4 commits into
python:masterpython/cpython:masterfrom
serhiy-storchaka:simple-common-dialog-temporary-rootserhiy-storchaka/cpython:simple-common-dialog-temporary-rootCopy head branch name to clipboard
Conversation
When simple query dialogs (tkinter.simpledialog), message boxes (tkinter.messagebox) or color choose dialog (tkinter.colorchooser) are created without arguments master and parent, and the default root window is not yet created, a new temporary hidden root window will be created automatically. It will not be set as the default root window and will be destroyed right after closing the dialog window. It will help to use these simple dialog windows in programs which do not need other GUI. Previously, message boxes and color chooser created the blank root window and left it after closing the dialog window, and query dialogs just raised an exception.
f1e7bfd to
2460120
Compare
terryjreedy
requested changes
Dec 24, 2020
terryjreedy
left a comment
Member
There was a problem hiding this comment.
Half of review is on issue.
|
When you're done making the requested changes, leave the comment: |
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Member
Author
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @terryjreedy: please review the changes made to this pull request. |
terryjreedy
reviewed
Dec 24, 2020
terryjreedy
approved these changes
Dec 24, 2020
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
…-23897) When simple query dialogs (tkinter.simpledialog), message boxes (tkinter.messagebox) or color choose dialog (tkinter.colorchooser) are created without arguments master and parent, and the default root window is not yet created, a new temporary hidden root window will be created automatically. It will not be set as the default root window and will be destroyed right after closing the dialog window. It will help to use these simple dialog windows in programs which do not need other GUI. Previously, message boxes and color chooser created the blank root window and left it after closing the dialog window, and query dialogs just raised an exception. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
wucke13
added a commit
to wucke13/linuxcnc
that referenced
this pull request
May 14, 2026
- Numpy renamed `numpy.core.Inf` -> `numpy.core.inf`.
- However, `numpy.core` was also deprecated and renamed, hence it
would be `numpy._core.inf`.
- But really, `numpy.inf` does work too.
- Avoid closing the `tkinter._default_root`, it's not necessary anymore
(probably since python/cpython#23897).
Nowadays, there isn't even a `tkinter._default_root` per default.
Signed-off-by: wucke13 <wucke13+github@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When simple query dialogs (tkinter.simpledialog), message boxes
(tkinter.messagebox) or color choose dialog (tkinter.colorchooser)
are created without arguments master and parent, and the default
root window is not yet created, a new temporary hidden root window
will be created automatically. It will not be set as the default root
window and will be destroyed right after closing the dialog window.
It will help to use these simple dialog windows in programs which do
not need other GUI.
Previously, message boxes and color chooser created the blank root
window and left it after closing the dialog window, and query dialogs
just raised an exception.
https://bugs.python.org/issue42721