Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-41116: Fix setup.py test for macOS Tcl/Tk frameworks#23649

Merged
ned-deily merged 2 commits into
python:masterpython/cpython:masterfrom
ned-deily:tcltk_fw_detectned-deily/cpython:tcltk_fw_detectCopy head branch name to clipboard
Dec 5, 2020
Merged

bpo-41116: Fix setup.py test for macOS Tcl/Tk frameworks#23649
ned-deily merged 2 commits into
python:masterpython/cpython:masterfrom
ned-deily:tcltk_fw_detectned-deily/cpython:tcltk_fw_detectCopy head branch name to clipboard

Conversation

@ned-deily

@ned-deily ned-deily commented Dec 5, 2020

Copy link
Copy Markdown
Member

If no explicit macOS SDK was specified, setup.py should check for
Tcl and TK frameworks in /Library/Frameworks; the previous commit
inadvertently broke that test.

https://bugs.python.org/issue41116

If no explicit macOS SDK was specified, setup.py should check for
Tcl and TK frameworks in /Library/Frameworks; the previous commit
inadvertently broke that test.
@ned-deily ned-deily merged commit 29afab6 into python:master Dec 5, 2020
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @ned-deily for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@ned-deily ned-deily deleted the tcltk_fw_detect branch December 5, 2020 04:02
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2020
)

If no explicit macOS SDK was specified, setup.py should check for
Tcl and TK frameworks in /Library/Frameworks; the previous commit
inadvertently broke that test.
(cherry picked from commit 29afab6)

Co-authored-by: Ned Deily <nad@python.org>
@bedevere-bot

Copy link
Copy Markdown

GH-23650 is a backport of this pull request to the 3.9 branch.

ned-deily added a commit that referenced this pull request Dec 5, 2020
) (GH-23650)

If no explicit macOS SDK was specified, setup.py should check for
Tcl and TK frameworks in /Library/Frameworks; the previous commit
inadvertently broke that test.
(cherry picked from commit 29afab6)

Co-authored-by: Ned Deily <nad@python.org>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
)

If no explicit macOS SDK was specified, setup.py should check for
Tcl and TK frameworks in /Library/Frameworks; the previous commit
inadvertently broke that test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.